linux-kernel - Re: [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YKeydEDcqgiAYGgT@kroah.com>
Date:   Fri, 21 May 2021 15:15:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     arnd@...db.de, mihai.carabas@...cle.com,
        andriy.shevchenko@...ux.intel.com, pizhenwei@...edance.com,
        pbonzini@...hat.com, linqiheng@...wei.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] misc/pvpanic: Fix error handling in
 'pvpanic_pci_probe()'

On Fri, May 21, 2021 at 02:41:16PM +0200, Christophe JAILLET wrote:
> Le 21/05/2021 à 14:36, Greg KH a écrit :
> > On Sun, May 16, 2021 at 04:36:55PM +0200, Christophe JAILLET wrote:
> > > There is no error handling path in the probe function.
> > > Switch to managed resource so that errors in the probe are handled easily
> > > and simplify the remove function accordingly.
> > > 
> > > Fixes: db3a4f0abefd ("misc/pvpanic: add PCI driver")
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > > ---
> > >   drivers/misc/pvpanic/pvpanic-pci.c | 9 +++------
> > >   1 file changed, 3 insertions(+), 6 deletions(-)
> > 
> > I see two different series for these patches, so I don't know which to
> > take :(
> > 
> > Please fix up and send a v2 series so that I have a clue...
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> Both have to be taken. One is for -pci.c and one is for -mmio.c.

Ah, I totally missed that :(

> I'll resend both with a more complete subject and will include Andy
> Shevchenko's comments.

Wonderful, thanks for doing that.

greg k-h