linux-kernel - Re: [PATCH] ALSA: usb-audio: fix control-request direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hv97cf9tc.wl-tiwai@suse.de>
Date:   Fri, 21 May 2021 16:19:59 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Johan Hovold <johan@...nel.org>
Cc:     Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>,
        "Geoffrey D. Bennett" <g@...vu>, alsa-devel@...a-project.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: fix control-request direction

On Fri, 21 May 2021 15:37:42 +0200,
Johan Hovold wrote:
> 
> The direction of the pipe argument must match the request-type direction
> bit or control requests may fail depending on the host-controller-driver
> implementation.
> 
> Fix the UAC2_CS_CUR request which erroneously used usb_sndctrlpipe().
> 
> Fixes: 93db51d06b32 ("ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3")
> Cc: stable@...r.kernel.org      # 5.10
> Signed-off-by: Johan Hovold <johan@...nel.org>

Thanks, applied now.

> ---
> 
> There's a related bug in sound/usb/mixer_scarlett_gen2.c, which
> Geoffrey reported and said he was preparing a patch for here:
> 
> 	https://lore.kernel.org/r/20210520180819.GA95348@m.b4.vu

Yes, I'm going to apply them now, too.


Takashi