linux-kernel - RE: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS3PR01MB6593794BFE3A4A08C62E708BBA299@OS3PR01MB6593.jpnprd01.prod.outlook.com>
Date:   Fri, 21 May 2021 14:36:23 +0000
From:   Min Li <min.li.xe@...esas.com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     "sameo@...ux.intel.com" <sameo@...ux.intel.com>,
        "grant.likely@...aro.org" <grant.likely@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit
 (SMU) support

> >
> > +config MFD_RSMU_I2C
> > +	tristate "Renesas Synchronization Management Unit with I2C"
> > +	depends on I2C && OF
> > +	depends on MFD_RSMU_SPI=n
> 
> Not sure I've seen a relationship like this before.
> 
> Devices capable of SPI and I2C usually have a core driver which selects one
> or the other.  It will also save some code duplication you have here.  Please
> take a look at some other examples in the MFD subsystem.


Hi Lee

Thanks for taking your time to review my code. I will start working on the core driver. But
Kconfig items will stay as MFD_RSMU_I2C and MFD_RSMU_SPI like the existing ones 

MFD_MADERA_SPI
MFD_MADERA_I2C

MFD_DA9052_SPI
MFD_DA9052_I2C

MFD_MC13XXX_SPI
MFD_MC13XXX_I2C

Min