linux-kernel - Re: [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47bf2b41-d42f-fb25-ee9e-5527f3324b17@gmail.com>
Date:   Fri, 21 May 2021 08:08:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     "Ivan T. Ivanov" <iivanov@...e.de>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     Phil Elwell <phil@...pberrypi.com>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-gpio@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: bcm2835: Accept fewer than expected IRQs



On 5/21/2021 2:01 AM, Ivan T. Ivanov wrote:
> From: Phil Elwell <phil@...pberrypi.com>
> 
> The downstream .dts files only request two GPIO IRQs. Truncate the
> array of parent IRQs when irq_of_parse_and_map returns 0.
> 
> Signed-off-by: Phil Elwell <phil@...pberrypi.com>
> Signed-off-by: Ivan T. Ivanov <iivanov@...e.de>
> ---
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 1d21129f7751..2c87af1180c4 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -1274,9 +1274,13 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev)
>  		char *name;
>  
>  		girq->parents[i] = irq_of_parse_and_map(np, i);
> -		if (!is_7211)
> +		if (!is_7211) {
> +			if (!girq->parents[i]) {
> +				girq->num_parents = i;
> +				break;
> +			}
>  			continue;

This assumes that interrupts are specified in an ordered way and skipped
in an ordered way as well, however given that we just hand
girq->parents[] to the GPIOLIB core, I don't really see a better solution:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian