linux-kernel - Re: [PATCH] ALSA: usb-audio: initialize the cur variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 May 2021 08:46:10 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     trix@...hat.com
Cc:     perex@...ex.cz, tiwai@...e.com, gustavoars@...nel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: initialize the cur variable

On Fri, 21 May 2021 21:46:03 +0200,
trix@...hat.com wrote:
> 
> From: Tom Rix <trix@...hat.com>
> 
> Static analysis reports this problem
> clock.c:338:10: warning: The right operand of '=='
>   is a garbage value
>     if (i == cur)
>           ^  ~~~
> 
> In __uac_clock_find_source() the goto find_others skips over
> setting of the 'cur' variable.  Since the pin loop variable
> starts with 1, it is safe to initialize cur to 0.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks for the patch, but this has been already fixed in for-next
branch.


Takashi