linux-kernel - Re: [PATCH v2 0/5] misc/pvpanic: Fix some errro handling path and simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 May 2021 13:03:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mihai Carabas <mihai.carabas@...cle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        pizhenwei@...edance.com, Paolo Bonzini <pbonzini@...hat.com>,
        bobo.shaobowang@...wei.com, linqiheng@...wei.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2 0/5] misc/pvpanic: Fix some errro handling path and
 simplify code

On Sat, May 22, 2021 at 9:54 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> This serie was previously sent in 2 parts, one for -pci.c and one for
> -mmio.c.
> Execpt the patch 5/5 which is new, the 4 first patches are the same as the
> ones previously posted. Only the description has been slighly updated.
>
> Pacth 5/5 is a proposal to simplify code and turn 'pvpanic_probe()' into a
> fully resource managed version.
> This way callers don't need to do some clean-up on error in the
> probe and on remove.
>
>
> "Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>" was only
> added on patch 1 and 3. I was unsure if his Reviewed-by was also related to
> the s/GFP_ATOMIC/GFP_KERNEL/ of patch 2 et 4.

To be sure, always send a series with a cover letter :-)
Yes, 2 and 4 were also included.

> Christophe JAILLET (5):
>   misc/pvpanic-pci: Fix error handling in 'pvpanic_pci_probe()'
>   misc/pvpanic-pci: Use GFP_KERNEL instead of GFP_ATOMIC
>   misc/pvpanic-mmio: Fix error handling in 'pvpanic_mmio_probe()'
>   misc/pvpanic-mmio: Use GFP_KERNEL instead of GFP_ATOMIC
>   misc/pvpanic: Make 'pvpanic_probe()' resource managed
>
>  drivers/misc/pvpanic/pvpanic-mmio.c | 17 ++--------------
>  drivers/misc/pvpanic/pvpanic-pci.c  | 22 ++++-----------------
>  drivers/misc/pvpanic/pvpanic.c      | 30 ++++++++++++++---------------
>  drivers/misc/pvpanic/pvpanic.h      |  3 +--
>  4 files changed, 22 insertions(+), 50 deletions(-)
>
> --
> 2.30.2
>


-- 
With Best Regards,
Andy Shevchenko