linux-kernel - Re: [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKjbxhzD/yKQ6B2R@dU2104>
Date:   Sat, 22 May 2021 15:54:06 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 3/5] staging: media: atomisp: code formatting changes
 sh_css_params.c

On Fri, May 21, 2021 at 01:52:22PM +0300, Dan Carpenter wrote:
> On Sat, May 01, 2021 at 12:16:07PM +0530, Deepak R Varma wrote:
> > @@ -1562,8 +1544,10 @@ ia_css_isp_3a_statistics_map_allocate(
> >  	base_ptr = me->data_ptr;
> >  
> >  	me->size = isp_stats->size;
> > -	/* GCC complains when we assign a char * to a void *, so these
> > -	 * casts are necessary unfortunately. */
> > +	/*
> > +	 * GCC complains when we assign a char * to a void *, so these
> > +	 * casts are necessary unfortunately.
> > +	 */
> 
> Not related to your patch, but assigning a char pointer to a void
> pointer is fine and GCC will not complain.  The problem is that
> me->dmem_stats is not a void pointer.  Someone should delete that
> nonsense comment.

I agree. Well caught. I will remove these comments and send v2. Waiting for feedback
on other patches of this series.

deepak.

> 
> >  	me->dmem_stats    = (void *)base_ptr;
> >  	me->vmem_stats_hi = (void *)(base_ptr + isp_stats->dmem_size);
> >  	me->vmem_stats_lo = (void *)(base_ptr + isp_stats->dmem_size +
> 
> regards,
> dan carpenter