linux-kernel - Re: [PATCH v2] kbuild: replace LANG=C with LC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAST-2CDycoAsKEmVw-56um7HHs07smaWemsOsL8eo+F6w@mail.gmail.com>
Date:   Sat, 22 May 2021 11:14:24 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     patchwork-bot+linux-kselftest@...nel.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] kbuild: replace LANG=C with LC_ALL=C

On Sat, May 22, 2021 at 3:34 AM
<patchwork-bot+linux-kselftest@...nel.org> wrote:
>
> Hello:
>
> This patch was applied to shuah/linux-kselftest.git (refs/heads/next):
>
> On Fri, 30 Apr 2021 10:56:27 +0900 you wrote:
> > LANG gives a weak default to each LC_* in case it is not explicitly
> > defined. LC_ALL, if set, overrides all other LC_* variables.
> >
> >   LANG  <  LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ...  <  LC_ALL
> >
> > This is why documentation such as [1] suggests to set LC_ALL in build
> > scripts to get the deterministic result.
> >
> > [...]
>
> Here is the summary with links:
>   - [v2] kbuild: replace LANG=C with LC_ALL=C
>     https://git.kernel.org/shuah/linux-kselftest/c/77a88274dc1a
>
> You are awesome, thank you!
> --


Huh?

This patch exists in Linus' tree.

Why is this going to the kselftest tree
in the first place?



commit 77a88274dc1a2cf3a775161d9a3242bc798ee680
Author: Masahiro Yamada <masahiroy@...nel.org>
Date:   Fri Apr 30 10:56:27 2021 +0900

    kbuild: replace LANG=C with LC_ALL=C

    LANG gives a weak default to each LC_* in case it is not explicitly
    defined. LC_ALL, if set, overrides all other LC_* variables.

      LANG  <  LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ...  <  LC_ALL

    This is why documentation such as [1] suggests to set LC_ALL in build
    scripts to get the deterministic result.

    LANG=C is not strong enough to override LC_* that may be set by end
    users.

    [1]: https://reproducible-builds.org/docs/locales/

    Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
    Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)
    Reviewed-by: Matthias Maennich <maennich@...gle.com>
    Acked-by: Matthieu Baerts <matthieu.baerts@...sares.net> (mptcp)
    Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>






--
Best Regards
Masahiro Yamada