linux-kernel - Re: [PATCH v6 14/20] vfio/mdev: idxd: add 1dwq-v1 mdev type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210523234733.GK1002214@nvidia.com>
Date:   Sun, 23 May 2021 20:47:33 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     alex.williamson@...hat.com, kwankhede@...dia.com,
        tglx@...utronix.de, vkoul@...nel.org, megha.dey@...el.com,
        jacob.jun.pan@...el.com, ashok.raj@...el.com, yi.l.liu@...el.com,
        baolu.lu@...el.com, kevin.tian@...el.com, sanjay.k.kumar@...el.com,
        tony.luck@...el.com, dan.j.williams@...el.com,
        eric.auger@...hat.com, pbonzini@...hat.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH v6 14/20] vfio/mdev: idxd: add 1dwq-v1 mdev type

On Fri, May 21, 2021 at 05:20:31PM -0700, Dave Jiang wrote:
> Add mdev device type "1dwq-v1" support code. 1dwq-v1 is defined as a
> single DSA gen1 dedicated WQ. This WQ cannot be shared between guests. The
> guest also cannot change any WQ configuration.
> 
> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
>  drivers/vfio/mdev/idxd/mdev.c |  173 +++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 166 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/vfio/mdev/idxd/mdev.c b/drivers/vfio/mdev/idxd/mdev.c
> index e484095baeea..9f6c4997ec24 100644
> +++ b/drivers/vfio/mdev/idxd/mdev.c
> @@ -22,6 +22,13 @@
>  #include "idxd.h"
>  #include "mdev.h"
>  
> +static const char idxd_dsa_1dwq_name[] = "dsa-1dwq-v1";
> +static const char idxd_iax_1dwq_name[] = "iax-1dwq-v1";

Dare I ask why this is "v1"? If you need to significantly change
something you should make a whole new mdev.

Jason