linux-kernel - Re: [PATCH] riscv: kprobes: Fix build error when MMU=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-6c70b6b6-7828-403a-93f9-5814edb3e201@palmerdabbelt-glaptop>
Date:   Sat, 22 May 2021 22:07:32 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     jszhang3@...l.ustc.edu.cn
CC:     Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:     Re: [PATCH] riscv: kprobes: Fix build error when MMU=n

On Sat, 08 May 2021 08:43:47 PDT (-0700), jszhang3@...l.ustc.edu.cn wrote:
> From: Jisheng Zhang <jszhang@...nel.org>
>
> lkp reported a randconfig failure:
>
> arch/riscv/kernel/probes/kprobes.c:90:22: error: use of undeclared identifier 'PAGE_KERNEL_READ_EXEC'
>
> We implemented the alloc_insn_page() to allocate PAGE_KERNEL_READ_EXEC
> page for kprobes insn page for STRICT_MODULE_RWX. But if MMU=n, we
> should fall back to the generic weak alloc_insn_page() by generic
> kprobe subsystem.
>
> Fixes: cdd1b2bd358f ("riscv: kprobes: Implement alloc_insn_page()")
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
>  arch/riscv/kernel/probes/kprobes.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/kernel/probes/kprobes.c b/arch/riscv/kernel/probes/kprobes.c
> index 10b965c34536..15cc65ac7ca6 100644
> --- a/arch/riscv/kernel/probes/kprobes.c
> +++ b/arch/riscv/kernel/probes/kprobes.c
> @@ -84,6 +84,7 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p)
>  	return 0;
>  }
>
> +#ifdef CONFIG_MMU
>  void *alloc_insn_page(void)
>  {
>  	return  __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END,
> @@ -91,6 +92,7 @@ void *alloc_insn_page(void)
>  				     VM_FLUSH_RESET_PERMS, NUMA_NO_NODE,
>  				     __builtin_return_address(0));
>  }
> +#endif
>
>  /* install breakpoint in text */
>  void __kprobes arch_arm_kprobe(struct kprobe *p)

Thanks, this is on fixes.