linux-kernel - Re: [PATCH -next] USB: gadget: f_fs: Use ERR_CAST instead of ERR_PTR(PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 23 May 2021 14:33:36 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <balbi@...nel.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] USB: gadget: f_fs: Use ERR_CAST instead of
 ERR_PTR(PTR_ERR(...))



On 2021/5/21 19:48, Greg KH wrote:
> On Wed, May 19, 2021 at 10:30:32AM +0800, YueHaibing wrote:
>> A coccicheck run provided information like the following.
>>
>> ./drivers/usb/gadget/function/f_fs.c:3832:9-16:
>>  WARNING: ERR_CAST can be used with data
>>
>> Use ERR_CAST to fix this.
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/usb/gadget/function/f_fs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
>> index bf109191659a..61110ff52f49 100644
>> --- a/drivers/usb/gadget/function/f_fs.c
>> +++ b/drivers/usb/gadget/function/f_fs.c
>> @@ -3829,7 +3829,7 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len)
>>  
>>  	data = memdup_user(buf, len);
>>  	if (IS_ERR(data))
>> -		return ERR_PTR(PTR_ERR(data));
>> +		return ERR_CAST(data);
> 
> This should just be:
> 		return PTR_ERR(data);
> right?

ffs_prepare_buffer() should return an ERR_PTR() encoded error code on failure,

maybe there just do:

		return data;

> 
> No need for 2 casts to happen here.
> 
> thanks,
> 
> greg k-h
> .
>