linux-kernel - Re: [PATCH] OF: of_address: clean up OF stub functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 23 May 2021 15:49:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Randy Dunlap <rdunlap@...radead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH] OF: of_address: clean up OF stub functions

Hi Randy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linux/master linus/master v5.13-rc2 next-20210521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Randy-Dunlap/OF-of_address-clean-up-OF-stub-functions/20210523-102857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: sparc64-randconfig-p002-20210523 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c304e793a2b36d66328db9c7899a4b1817063155
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Randy-Dunlap/OF-of_address-clean-up-OF-stub-functions/20210523-102857
        git checkout c304e793a2b36d66328db9c7899a4b1817063155
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/sparc/kernel/of_device_common.c:27:5: error: redefinition of 'of_address_to_resource'
      27 | int of_address_to_resource(struct device_node *node, int index,
         |     ^~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/sparc/kernel/of_device_common.c:10:
   include/linux/of_address.h:110:19: note: previous definition of 'of_address_to_resource' was here
     110 | static inline int of_address_to_resource(struct device_node *dev, int index,
         |                   ^~~~~~~~~~~~~~~~~~~~~~
>> arch/sparc/kernel/of_device_common.c:40:15: error: redefinition of 'of_iomap'
      40 | void __iomem *of_iomap(struct device_node *node, int index)
         |               ^~~~~~~~
   In file included from arch/sparc/kernel/of_device_common.c:10:
   include/linux/of_address.h:116:29: note: previous definition of 'of_iomap' was here
     116 | static inline void __iomem *of_iomap(struct device_node *device, int index)
         |                             ^~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for LOCKDEP
   Depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && (FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86)
   Selected by
   - LOCK_STAT && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
   - DEBUG_LOCK_ALLOC && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT


vim +/of_address_to_resource +27 arch/sparc/kernel/of_device_common.c

c9f5b7e77c30da2 Robert Reif     2009-06-04  26  
930952af15f8425 David S. Miller 2011-03-18 @27  int of_address_to_resource(struct device_node *node, int index,
930952af15f8425 David S. Miller 2011-03-18  28  			   struct resource *r)
930952af15f8425 David S. Miller 2011-03-18  29  {
930952af15f8425 David S. Miller 2011-03-18  30  	struct platform_device *op = of_find_device_by_node(node);
930952af15f8425 David S. Miller 2011-03-18  31  
930952af15f8425 David S. Miller 2011-03-18  32  	if (!op || index >= op->num_resources)
930952af15f8425 David S. Miller 2011-03-18  33  		return -EINVAL;
930952af15f8425 David S. Miller 2011-03-18  34  
930952af15f8425 David S. Miller 2011-03-18  35  	memcpy(r, &op->archdata.resource[index], sizeof(*r));
930952af15f8425 David S. Miller 2011-03-18  36  	return 0;
930952af15f8425 David S. Miller 2011-03-18  37  }
930952af15f8425 David S. Miller 2011-03-18  38  EXPORT_SYMBOL_GPL(of_address_to_resource);
930952af15f8425 David S. Miller 2011-03-18  39  
9889376ab91f89a David S. Miller 2011-03-18 @40  void __iomem *of_iomap(struct device_node *node, int index)
9889376ab91f89a David S. Miller 2011-03-18  41  {
9889376ab91f89a David S. Miller 2011-03-18  42  	struct platform_device *op = of_find_device_by_node(node);
9889376ab91f89a David S. Miller 2011-03-18  43  	struct resource *r;
9889376ab91f89a David S. Miller 2011-03-18  44  
9889376ab91f89a David S. Miller 2011-03-18  45  	if (!op || index >= op->num_resources)
9889376ab91f89a David S. Miller 2011-03-18  46  		return NULL;
9889376ab91f89a David S. Miller 2011-03-18  47  
9889376ab91f89a David S. Miller 2011-03-18  48  	r = &op->archdata.resource[index];
9889376ab91f89a David S. Miller 2011-03-18  49  
9889376ab91f89a David S. Miller 2011-03-18  50  	return of_ioremap(r, 0, resource_size(r), (char *) r->name);
9889376ab91f89a David S. Miller 2011-03-18  51  }
9889376ab91f89a David S. Miller 2011-03-18  52  EXPORT_SYMBOL(of_iomap);
9889376ab91f89a David S. Miller 2011-03-18  53  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31578 bytes)