linux-kernel - Re: [PATCH] staging: vchiq_arm: Using copy_from_user() to copy data from userspace address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 May 2021 01:26:23 +0800
From:   Phi Nguyen <phind.uet@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     nsaenz@...nel.org, gregkh@...uxfoundation.org,
        stefan.wahren@...e.com, arnd@...db.de, dan.carpenter@...cle.com,
        phil@...pberrypi.com, amarjargal16@...il.com,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vchiq_arm: Using copy_from_user() to copy data
 from userspace address

On 22/5/21 2:33 pm, Al Viro wrote:
> On Sat, May 22, 2021 at 01:34:29PM +0800, Nguyen Dinh Phi wrote:
>> This commit to fix the following sparse warning:
>> incorrect type in assignment (different address spaces)
>> expected void *[assigned] userdata
>> got void [noderef] __user *userdata
>>
>> Signed-off-by: Nguyen Dinh Phi <phind.uet@...il.com>
>> ---
>>   .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c    | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> index afbf01b7364c..2a4fc599f977 100644
>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> @@ -960,7 +960,10 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance,
>>   			current->pid);
>>   		userdata = &waiter->bulk_waiter;
>>   	} else {
>> -		userdata = args->userdata;
>> +		if (copy_from_user(userdata, args->userdata, sizeof(args->userdata))) {
> 
> 	The contents of userdata (local variable of type void *) is uninitialized at that
> point.
Sorry, That was my mistake.

> Just what do you think that call of copy_from_user() would do? 

Because according to the definition of struct vchiq_queue_bulk_transfer, 
the args->userdata pointer is userspace address.