linux-kernel - Re: [PATCH] lib/math/rational.c: Fix divide by zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5511f68-814b-1f8c-08d2-a7dbddce4e8d@infradead.org>
Date:   Mon, 24 May 2021 15:04:21 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Daniel Latypov <dlatypov@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Trent Piepho <tpiepho@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        andy@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
        oskar@...ra.com, Yiyuan Guo <yguoaz@...il.com>
Subject: Re: [PATCH] lib/math/rational.c: Fix divide by zero

On 5/24/21 9:55 AM, Daniel Latypov wrote:
> diff --git a/lib/math/Kconfig b/lib/math/Kconfig
> index f19bc9734fa7..20460b567493 100644
> --- a/lib/math/Kconfig
> +++ b/lib/math/Kconfig
> @@ -15,3 +15,14 @@ config PRIME_NUMBERS
> 
>  config RATIONAL
>         bool
> +
> +config RATIONAL_KUNIT_TEST
> +       tristate "KUnit test for rational number support" if !KUNIT_ALL_TESTS
> +       # depends on KUNIT && RATIONAL  # this is how it should work, but
> +       depends on KUNIT
> +       select RATIONAL # I don't grok kconfig enough to know why this

Only to set the symbol CONFIG_RATIONAL.
Then when 'make' descends into the lib/math/ subdir and looks at its Makefile,
it will decide to build the binary rational.o.

obj-$(CONFIG_RATIONAL)		+= rational.o


> is necessary
> +       default KUNIT_ALL_TESTS
> +       help
> +               This builds unit tests for the rational number support.
> +
> +               If unsure, say N.


-- 
~Randy