linux-kernel - Re: [PATCH 00/39] irqdomain: Simplify interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sg2cwm17.wl-maz@kernel.org>
Date:   Mon, 24 May 2021 09:53:08 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Ley Foon Tan <ley.foon.tan@...el.com>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        Vineet Gupta <vgupta@...opsys.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Russell King <linux@...linux.org.uk>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Clark <robdclark@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [PATCH 00/39] irqdomain: Simplify interrupt handling

On Fri, 21 May 2021 00:33:58 +0100,
Linus Walleij <linus.walleij@...aro.org> wrote:
> 
> On Thu, May 20, 2021 at 6:37 PM Marc Zyngier <maz@...nel.org> wrote:
> 
> > Wouldn't it be nice if the irqdomain
> > would cache the irq_desc instead of forcing the core code to look it
> > up on each and every interrupt? This is what this long series is all
> > about.
> 
> For gpio and pinctrl bulk conversions:
> Acked-by: Linus Walleij <linus.walleij@...aro.org>

Thanks for that.

> I agree that Rob's idea to create a bitmap walker may be helpful
> if you have the energy for it, but this as a whole is nevertheless
> good.

I'll look into that once I figure out a good solution for handling
errors, which the caller should most probably be made aware of.

> Do they have to be applied en masse?

Not necessarily. As long as the initial infrastructure is in place,
maintainers can take the subsequent patches on their own time, as all
the original APIs are preserved.

> I think there could be some clashes and new drivers that will
> create weirdness in that case so an immutable branch for
> maintainers to pull in will be needed if you want it all in the
> next merge window.
> 
> Unless you plan to merge the bottom
> patches and then let subsystem maintainers convert each
> subsystem in the next merge window.
> 
> Or a base to be pulled in and then each subsystem can
> apply the bulk conversion to their subsystem only.

This last option is my preferred approach for busy subsystems. I'm
happy to take care of irqchip and of the quieter architectures such as
NIOS2 and SH, and leave the rest to their respective maintainers.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.