linux-kernel - Re: [PATCH v5 28/28] x86/fpu/amx: Clear the AMX state when appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff72d7cd-e36d-06d8-d741-645a0504bf65@intel.com>
Date:   Mon, 24 May 2021 07:10:07 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Andy Lutomirski <luto@...nel.org>,
        "Chang S. Bae" <chang.seok.bae@...el.com>, bp@...e.de,
        tglx@...utronix.de, mingo@...nel.org, x86@...nel.org
Cc:     len.brown@...el.com, jing2.liu@...el.com, ravi.v.shankar@...el.com,
        linux-kernel@...r.kernel.org, "Chen, Tim C" <tim.c.chen@...el.com>
Subject: Re: [PATCH v5 28/28] x86/fpu/amx: Clear the AMX state when
 appropriate

On 5/23/21 8:13 PM, Andy Lutomirski wrote:
>> +		/*
>> +		 * Since the current task's state is safely in the XSAVE buffer, TILERELEASE
>> +		 * the TILE registers to guarantee that dirty state will not interfere with the
>> +		 * hardware's ability to enter the core C6 idle state.
>> +		 */
>> +		if (fpu->state_mask & XFEATURE_MASK_XTILE_DATA)
>> +			tile_release();
>>  		return 1;
>>  	}
>>  
>>
> This looks wrong -- you should also invalidate the state.  And doing it
> in the save path seems inefficient.
> 
> Can we do this just when going idle?

Chang, you might also want to talk with folks that do scheduler
performance work (I've cc'd Tim).  I know we're always fighting to trim
down the idle and wakeup paths.  There might be no other alternative,
but unconditionally forcing an AMX XRSTOR on return from idle might be
considered nasty.