linux-kernel - Re: [PATCH] media: atomisp: Replace whitespace at the beginning of line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 May 2021 18:20:06 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Aniket Bhattacharyea <aniketmail669@...il.com>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        andriy.shevchenko@...ux.intel.com, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: atomisp: Replace whitespace at the beginning of
 line

Hi Aniket,

On Thu, May 20, 2021 at 09:20:13PM +0530, Aniket Bhattacharyea wrote:
> This patch replaces the whitespaces at the beginning of line with tabs.
> Identified by checkpatch: WARNING: please, no spaces at the start of a line.
> 
> Signed-off-by: Aniket Bhattacharyea <aniketmail669@...il.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> index 135994d44802..93ac7e183344 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -1041,9 +1041,9 @@ static struct camera_sensor_platform_data acpi_gmin_plat = {
>  };
>  
>  struct camera_sensor_platform_data *gmin_camera_platform_data(
> -    struct v4l2_subdev *subdev,
> -    enum atomisp_input_format csi_format,
> -    enum atomisp_bayer_order csi_bayer)
> +	struct v4l2_subdev *subdev,
> +	enum atomisp_input_format csi_format,
> +	enum atomisp_bayer_order csi_bayer)

Please wrap instead after the type if the type and name are too long.

I.e.

struct camera_sensor_platform_data *
gmin_camera_platform_data(...,
			  ...);

>  {
>  	u8 pmic_i2c_addr = gmin_detect_pmic(subdev);
>  	struct gmin_subdev *gs;

-- 
Regards,

Sakari Ailus