linux-kernel - Re: [PATCH] iio: accel: fxls8962af: conditionally compile fxls8962af_i2c_raw_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YK1efL7DMOVZSPuz@kunai>
Date:   Tue, 25 May 2021 22:30:52 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Sean Nyekjaer <sean@...nix.com>, trix@...hat.com, lars@...afoo.de,
        andy.shevchenko@...il.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] iio: accel: fxls8962af: conditionally compile
 fxls8962af_i2c_raw_read_errata3()


> > > The build is failing with this link error
> > > ld: fxls8962af-core.o: in function `fxls8962af_fifo_transfer':
> > > fxls8962af-core.c: undefined reference to `i2c_verify_client'
> > > 
> > > This is needed for the i2c variant, not the spi variant. So
> > > conditionally compile based on CONFIG_FXLS8962AF_I2C.
> > >   
> > Fixes: 68068fad0e1c ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
> > > Signed-off-by: Tom Rix <trix@...hat.com>  
> > Reviewed-by: Sean Nyekjaer <sean@...nix.com>
> 
> Given the purpose of that check is to verify it was an i2c_client
> should we be looking to instead provide a stub for the case where
> we don't have CONFIG_I2C?
> 
> +CC Wolfram and linux-i2c list for input.

Such a stub sounds reasonable.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)