linux-kernel - Re: [PATCH net-next v2] atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210525.152322.1873282589367907213.davem@davemloft.net>
Date:   Tue, 25 May 2021 15:23:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gatis@...rotik.com
Cc:     chris.snook@...il.com, kuba@...nel.org, hkallweit1@...il.com,
        jesse.brandeburg@...el.com, dchickles@...vell.com,
        tully@...rotik.com, eric.dumazet@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] atl1c: add 4 RX/TX queue support for
 Mikrotik 10/25G NIC

From: Gatis Peisenieks <gatis@...rotik.com>
Date: Tue, 25 May 2021 11:19:33 +0300

> More RX/TX queues on a network card help spread the CPU load among
> cores and achieve higher overall networking performance. The new
> Mikrotik 10/25G NIC supports 4 RX and 4 TX queues. TX queues are
> treated with equal priority. RX queue balancing is fixed based on
> L2/L3/L4 hash.
> 
> This adds support for 4 RX/TX queues while maintaining backwards
> compatibility with older hardware.
> 
> Simultaneous TX + RX performance on AMD Threadripper 3960X
> with Mikrotik 10/25G NIC improved from 1.6Mpps to 3.2Mpps per port.
> 
> Backwards compatiblitiy was verified with AR8151 and AR8131 based
> NICs.
> 
> Signed-off-by: Gatis Peisenieks <gatis@...rotik.com>
> ---
> v2:
>         - rebase on net-next master as requested by David Miller

Please fix these warnings:
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Function parameter or member 'queue' not described in 'atl1c_clean_tx_ring'
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Excess function parameter 'type' description in 'atl1c_clean_tx_ring'
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:917: warning: Function parameter or member 'queue' not described in 'atl1c_clean_rx_ring'
New warnings added
0a1,3
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Function parameter or member 'queue' not described in 'atl1c_clean_tx_ring'
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Excess function parameter 'type' description in 'atl1c_clean_tx_ring'
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:917: warning: Function parameter or member 'queue' not described in 'atl1c_clean_rx_ring'
Per-file breakdown

Thank you.