linux-kernel - Re: [PATCH v2] ARM: dts: sun8i: v3s: enable emac for zero Dock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210525080621.m7qpnfdarkrg3vn5@gilmour>
Date:   Tue, 25 May 2021 10:06:21 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Andreas Rehn <rehn.andreas86@...il.com>
Cc:     wens@...e.org, jernej.skrabec@...il.com,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: dts: sun8i: v3s: enable emac for zero Dock

Hi Andreas,

On Sun, May 23, 2021 at 12:23:29AM +0200, Andreas Rehn wrote:
> dwmac-sun8i supports v3s and
> Licheepi-zero Dock provides an ethernet port
> 
> Signed-off-by: Andreas Rehn <rehn.andreas86@...il.com>
> ---
> Changes in v2:
> 	- add ethernet0 alias.
> 
>  arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> index db5cd0b8574b..4d564028f286 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -49,6 +49,10 @@ / {
>  	compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
>  		     "allwinner,sun8i-v3s";
>  
> +	aliases {
> +		ethernet0 = &emac;
> +	};
> +
>  	leds {
>  		/* The LEDs use PG0~2 pins, which conflict with MMC1 */
>  		status = "disabled";
> @@ -94,3 +98,8 @@ button-800 {
>  		voltage = <800000>;
>  	};
>  };
> +
> +&emac {
> +	allwinner,leds-active-low;
> +	status = "okay";
> +};

We use alphabetical order for phandle derefences

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)