linux-kernel - Re: [PATCH] lib/math/rational.c: Fix divide by zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7tXihtuzw3+7boMFqmvHcpe-hr2qF0TnaduskbXUbfsFwb=A@mail.gmail.com>
Date:   Tue, 25 May 2021 02:21:08 -0700
From:   Trent Piepho <tpiepho@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Daniel Latypov <dlatypov@...gle.com>, linux-kernel@...r.kernel.org,
        andy@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
        Oskar Schirmer <oskar@...ra.com>, Yiyuan Guo <yguoaz@...il.com>
Subject: Re: [PATCH] lib/math/rational.c: Fix divide by zero

On Tue, May 25, 2021 at 2:02 AM Andy Shevchenko
<andriy.shevchenko@...el.com> wrote:
>
> On Mon, May 24, 2021 at 01:17:48PM -0700, Trent Piepho wrote:
> > On Mon, May 24, 2021 at 3:51 AM Andy Shevchenko
> > <andriy.shevchenko@...el.com> wrote:
> > > On Sat, May 22, 2021 at 05:18:06PM -0700, Trent Piepho wrote:
> > >
> > > This misses the test cases (*). Please, develop them with Daniel.
> > >
> > > *) We usually don't accept changes in the generic libraries without test cases.
> > >
> > > Fixes tag?
> >
> > Is there a bug report on a tracker?  I just got the email from Yigua.
>
> Fixes tag refers to the existing commit that brought the bug.
> Also you may need to add Reported-by tag since Yigua reported it.

I did add a Reported-by tag.  Wasn't clear to me fixing a specific
commit was entirely appropriate since not handling out of range values
correctly has been there all along.