linux-kernel - Re: [PATCH] esp: drop unneeded assignment in esp4_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210525102355.GW40979@gauss3.secunet.de>
Date:   Tue, 25 May 2021 12:23:55 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <yoshfuji@...ux-ipv6.org>, <dsahern@...nel.org>, <kuba@...nel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] esp: drop unneeded assignment in esp4_gro_receive()

On Sun, Apr 25, 2021 at 06:14:32PM +0800, Yang Li wrote:
> Making '!=' operation with 0 directly after calling
> the function xfrm_parse_spi() is more efficient,
> assignment to err is redundant.
> 
> Eliminate the following clang_analyzer warning:
> net/ipv4/esp4_offload.c:41:7: warning: Although the value stored to
> 'err' is used in the enclosing expression, the value is never actually
> read from 'err'
> 
> No functional change, only more efficient.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Now applied to ipsec-next, thanks!