linux-kernel - Re: Patch regression - Re: [PATCH 5.10 070/104] dm snapshot: fix a crash when an origin has no snapshots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.02.2105250754370.14946@file01.intranet.prod.int.rdu2.redhat.com>
Date:   Tue, 25 May 2021 07:58:05 -0400 (EDT)
From:   Mikulas Patocka <mpatocka@...hat.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Michael Tokarev <mjt@....msk.ru>,
        Mike Snitzer <snitzer@...hat.com>,
        Zdenek Kabelac <zkabelac@...hat.com>
Subject: Re: Patch regression - Re: [PATCH 5.10 070/104] dm snapshot: fix a
 crash when an origin has no snapshots



On Tue, 25 May 2021, Greg Kroah-Hartman wrote:

> On Tue, May 25, 2021 at 07:36:57AM -0400, Mikulas Patocka wrote:
> > Hi Greg
> > 
> > I'd like to ask you to drop this patch from all stable branches.
> > 
> > It causes regression with snapshot merging and the regression is much 
> > worse than the bug that it fixes.
> 
> Sure, but is there a fix in Linus's branch for this that I should take
> instead, or is it reverted in linux-next already?
> 
> thanks,
> 
> greg k-h

There is no fix now - but the bug that this fixed is minor (it fixes a 
crash in a configuration that is never set by lvm2) - and the regression 
is major (snapshot merging doesn't work).

I'll work with Mike on reverting it a providing a proper fix.

Mikulas