linux-kernel - Re: [PATCH 2/9] rtc: bd70528: Drop BD70528 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83c091bef8adecd06a5c6fac9c86ca572bcc06d4.camel@fi.rohmeurope.com>
Date:   Tue, 25 May 2021 11:59:58 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>
CC:     "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        linux-power <linux-power@...rohmeurope.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH 2/9] rtc: bd70528: Drop BD70528 support


On Tue, 2021-05-25 at 13:47 +0200, Alexandre Belloni wrote:
> On 25/05/2021 13:14:09+0300, Matti Vaittinen wrote:
> > The only known BD70528 use-cases are such that the PMIC is
> > controlled
> > from separate MCU which is not running Linux. I am not aware of
> > any Linux driver users. Furthermore, it seems there is no demand
> > for
> > this IC. Let's ease the maintenance burden and drop the driver. We
> > can
> > always add it back if there is sudden need for it.
> > 
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> > 
> > ---
> > My heart is a bit less bleeding when I see how much simpler this
> > RTC
> > driver became..
> > Please let me know if some of you think the driver is needed.
> > ---
> >  drivers/rtc/Kconfig       |   4 +-
> >  drivers/rtc/rtc-bd70528.c | 316 ++------------------------------
> > ------
> >  2 files changed, 13 insertions(+), 307 deletions(-)
> > 
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index d8c13fded164..398899217626 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -502,10 +502,10 @@ config RTC_DRV_M41T80_WDT
> >  
> >  config RTC_DRV_BD70528
> >  	tristate "ROHM BD70528, BD71815 and BD71828 PMIC RTC"
> > -	depends on MFD_ROHM_BD71828 || MFD_ROHM_BD70528 &&
> > (BD70528_WATCHDOG || !BD70528_WATCHDOG)
> > +	depends on MFD_ROHM_BD71828
> 
> This won't apply as I applied b0ddc5b17005 ("rtc: bd70528: fix
> BD71815
> watchdog dependency") yesterday...
> 

I know Alexandre. Sorry about that. I received confirmation to my
question whether the BD70528 is used only at this morning. Sorry for
all the work.

This is why the cover-letter stated:

"...As a final note - Few improvements/fixes were just applied to the
regulator tree so this series is likely to conflict. Some fixes
were also added to RTC Kconfig - which means also the RTC tree
may have conflicts. Please let me know if you wish me to rebase
this series or those patches."

And in any case applying the MFD and RTC patches should be synced. RTC
parts should be applied before MFD parts because few other PMICs use
this same RTC driver and compilation would fail with missing headers if
MFD was removed before RTC changes are applied.

Suggestions on how to guarantee the order of MFD and RTC - and how to
resolve conflicts?

Best Regards
	Matti Vaittinen