linux-kernel - Re: [PATCH 3/3] x86/syscalls: Don't sdjust CFLAGS for syscall tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 May 2021 21:01:53 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Brian Gerst <brgerst@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        X86 ML <x86@...nel.org>, Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 3/3] x86/syscalls: Don't sdjust CFLAGS for syscall tables

On Tue, May 25, 2021 at 3:17 AM Brian Gerst <brgerst@...il.com> wrote:
>
> The syscall_*.c files only contain data (the syscall tables).  There
> is no need to adjust CFLAGS for tracing and stack protector since they
> contain no code.
>
> Signed-off-by: Brian Gerst <brgerst@...il.com>
> ---

Reviewed-by: Masahiro Yamada <masahiroy@...nel.org>

>  arch/x86/entry/Makefile | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
> index 94d2843ce80c..7fec5dcf6438 100644
> --- a/arch/x86/entry/Makefile
> +++ b/arch/x86/entry/Makefile
> @@ -8,14 +8,8 @@ UBSAN_SANITIZE := n
>  KCOV_INSTRUMENT := n
>
>  CFLAGS_REMOVE_common.o         = $(CC_FLAGS_FTRACE)
> -CFLAGS_REMOVE_syscall_64.o     = $(CC_FLAGS_FTRACE)
> -CFLAGS_REMOVE_syscall_32.o     = $(CC_FLAGS_FTRACE)
> -CFLAGS_REMOVE_syscall_x32.o    = $(CC_FLAGS_FTRACE)
>
>  CFLAGS_common.o                        += -fno-stack-protector
> -CFLAGS_syscall_64.o            += -fno-stack-protector
> -CFLAGS_syscall_32.o            += -fno-stack-protector
> -CFLAGS_syscall_x32.o           += -fno-stack-protector
>
>  obj-y                          := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
>  obj-y                          += common.o
> --
> 2.31.1
>


-- 
Best Regards
Masahiro Yamada