linux-kernel - Re: [PATCH v2 4/4] perf arm-spe: Remove redundant checking for "full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YKzypV/rlCDXg0Q0@kernel.org>
Date:   Tue, 25 May 2021 09:50:45 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     James Clark <james.clark@....com>
Cc:     Leo Yan <leo.yan@...aro.org>, John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Al Grant <Al.Grant@....com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] perf arm-spe: Remove redundant checking for
 "full_auxtrace"

Em Tue, May 25, 2021 at 03:03:53PM +0300, James Clark escreveu:
> 
> 
> On 19/05/2021 07:15, Leo Yan wrote:
> > The option "opts->full_auxtrace" is checked at the earlier place, if it
> > is false the function will directly bail out.  So remove the redundant
> > checking for "opts->full_auxtrace".
> > 
> > Suggested-by: James Clark <james.clark@....com>
> > Signed-off-by: Leo Yan <leo.yan@...aro.org>
> > ---
> >  tools/perf/arch/arm64/util/arm-spe.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c
> > index bacdf366040d..a4420d4df503 100644
> > --- a/tools/perf/arch/arm64/util/arm-spe.c
> > +++ b/tools/perf/arch/arm64/util/arm-spe.c
> > @@ -116,7 +116,7 @@ static int arm_spe_recording_options(struct auxtrace_record *itr,
> >  		return 0;
> >  
> >  	/* We are in full trace mode but '-m,xyz' wasn't specified */
> > -	if (opts->full_auxtrace && !opts->auxtrace_mmap_pages) {
> > +	if (!opts->auxtrace_mmap_pages) {
> >  		if (privileged) {
> >  			opts->auxtrace_mmap_pages = MiB(4) / page_size;
> >  		} else {
> > 
> 
> Reviewed-by: James Clark <james.clark@....com>

Thanks, applied the series,

- Arnaldo