linux-kernel - Re: [PATCH] perf vendor events: Fix eventcode of power10 json events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210525144215.GA2135213@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com>
Date:   Tue, 25 May 2021 09:42:15 -0500
From:   "Paul A. Clarke" <pc@...ibm.com>
To:     Kajol Jain <kjain@...ux.ibm.com>
Cc:     acme@...nel.org, maddy@...ux.vnet.ibm.com,
        atrajeev@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
        jolsa@...hat.com, mpe@...erman.id.au, ravi.bangoria@...ux.ibm.com,
        linux-perf-users@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        rnsastry@...ux.ibm.com
Subject: Re: [PATCH] perf vendor events: Fix eventcode of power10 json events

On Tue, May 25, 2021 at 12:07:23PM +0530, Kajol Jain wrote:
> Fixed the eventcode values in the power10 json event files to append
> "0x" since these are hexadecimal values.
> Patch also changes event description of PM_EXEC_STALL_LOAD_FINISH and
> PM_EXEC_STALL_NTC_FLUSH event and move some events to correct files.
> 
> Fixes: 32daa5d7899e ("perf vendor events: Initial JSON/events list for power10 platform")
> Signed-off-by: Kajol Jain <kjain@...ux.ibm.com>

I checked that everything that was "removed" was actually just moved
somewhere else, that all the added EventCodes indeed had '0x', the
number of EventCodes added matched the number removed, and that the
additional text added seemed reasonable.  LGTM.

Reviewed-by: Paul A. Clarke <pc@...ibm.com>