linux-kernel - Re: [PATCH] drm/amdgpu: remove unreachable code

Open Source and information security mailing list archives

Date:   Tue, 25 May 2021 11:38:47 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <ckoenig.leichtzumerken@...il.com>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Dave Airlie <airlied@...ux.ie>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@...ts.linaro.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        linux-media <linux-media@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: remove unreachable code

On Tue, May 25, 2021 at 11:27 AM Christian König
<ckoenig.leichtzumerken@...il.com> wrote:
>
> Am 24.05.21 um 20:48 schrieb Alex Deucher:
> > Applied.  Thanks!
>
> Ok, that's unfortunate.
>
> IIRC we added the code because of a different compiler warning.
>

I can revert it.

Alex

> Christian.
>
> >
> > Alex
> >
> > On Mon, May 24, 2021 at 6:47 AM Jiapeng Chong
> > <jiapeng.chong@...ux.alibaba.com> wrote:
> >> In the function amdgpu_uvd_cs_msg(), every branch in the switch
> >> statement will have a return, so the code below the switch statement
> >> will not be executed.
> >>
> >> Eliminate the follow smatch warning:
> >>
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:845 amdgpu_uvd_cs_msg() warn:
> >> ignoring unreachable code.
> >>
> >> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> >> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> >> ---
> >>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 --
> >>   1 file changed, 2 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> index 82f0542..375b346 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> @@ -842,8 +842,6 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,
> >>                  DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
> >>                  return -EINVAL;
> >>          }
> >> -       BUG();
> >> -       return -EINVAL;
> >>   }
> >>
> >>   /**
> >> --
> >> 1.8.3.1
> >>
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@...ts.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives