linux-kernel - Re: [PATCH] cpufreq: intel_pstate: hybrid: Fix build with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iVS0YR67M0b6V4p6Bk9gDR_x5YPVB0JYB8jBfQj0eKUw@mail.gmail.com>
Date:   Wed, 26 May 2021 19:12:33 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Chen Yu <yu.c.chen@...el.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: hybrid: Fix build with CONFIG_ACPI unset

On Wed, May 26, 2021 at 6:10 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 5/26/21 8:01 AM, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > One of the previous commits introducing hybrid processor support to
> > intel_pstate broke build with CONFIG_ACPI unset.
> >
> > Fix that and while at it fix up empty stubs of two functions related
> > to ACPI CPPC.
> >
> > Fixes: eb3693f0521e ("cpufreq: intel_pstate: hybrid: CPU-specific scaling factor")
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Hi Rafael,
>
> I still have this build error:
>
> ../drivers/cpufreq/intel_pstate.c: In function ‘show_base_frequency’:
> ../drivers/cpufreq/intel_pstate.c:950:10: error: implicit declaration of function ‘intel_pstate_get_cppc_guranteed’; did you mean ‘intel_pstate_get_epp’? [-Werror=implicit-function-declaration]
>   ratio = intel_pstate_get_cppc_guranteed(policy->cpu);

Well, I did too much in this patch, will send an update shortly.

> BTW: s/guranteed/guaranteed/g

Right.