linux-kernel - Re: [PATCH v7 2/5] soc: qcom: Add SoC sleep stats driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YK3H7m7bpL2DJt9R@builder.lan>
Date:   Tue, 25 May 2021 23:00:46 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Maulik Shah <mkshah@...eaurora.org>
Cc:     swboyd@...omium.org, mka@...omium.org, evgreen@...omium.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        agross@...nel.org, dianders@...omium.org, linux@...ck-us.net,
        rnayak@...eaurora.org, lsrao@...eaurora.org,
        Mahesh Sivasubramanian <msivasub@...eaurora.org>,
        Lina Iyer <ilina@...eaurora.org>
Subject: Re: [PATCH v7 2/5] soc: qcom: Add SoC sleep stats driver

On Fri 21 May 06:10 CDT 2021, Maulik Shah wrote:
> On 4/13/2021 5:13 AM, Bjorn Andersson wrote:
> > On Tue 06 Apr 05:27 CDT 2021, Maulik Shah wrote:
[..]
> > > diff --git a/drivers/soc/qcom/soc_sleep_stats.c b/drivers/soc/qcom/soc_sleep_stats.c
[..]
> > > +MODULE_SOFTDEP("pre: smem");
> > I believe this should be "qcom_smem",
> the module has smem.ko file so "smem" looks proper.
> >   but given that you call
> > qcom_smem_get() in your code you have a hard dependency in place
> > already. So, can you help me understand what use this softdep provide?
> 
> If both smem and soc_sleep_stats are compiled as DLKMs, this is to make sure
> smem module was loaded first by keeping pre soft dependency.
> 

But we're making a direct function call into the qcom_smem driver, so we
already have a hard dependency on qcom_smem.ko being loaded.

Regards,
Bjorn