linux-kernel - RE: [EXTERNAL] Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e9a178380914fc4bc9f7cef5f9d84f9@ti.com>
Date:   Wed, 26 May 2021 17:23:28 +0000
From:   "Tammana, Gowtham" <g-tammana@...com>
To:     Tony Lindgren <tony@...mide.com>, "Anna, Suman" <s-anna@...com>
CC:     "bcousson@...libre.com" <bcousson@...libre.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Strashko, Grygorii" <grygorii.strashko@...com>,
        "Menon, Nishanth" <nm@...com>
Subject: RE: [EXTERNAL] Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device
 node



>-----Original Message-----
>From: Tony Lindgren <tony@...mide.com>
>Sent: Tuesday, May 25, 2021 1:28 AM
>
>* Suman Anna <s-anna@...com> [210524 15:24]:
>> This can be fixed in couple of different ways, and I see there have been
>> different commits that have ultimately caused this.
>>  6b14eb4705d6 ("ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi")
>>  549fce068a31 ("ARM: dts: dra7: Add l4 interconnect hierarchy and ti-
>sysc data"
>>  bcbb63b80284 (ARM: dts: dra7: Separate AM57 dtsi files")
>>  c7b72abca61e ("ARM: OMAP2+: Drop legacy platform data for dra7 dwc3")
>>
>> Would you prefer that we just drop the USB4 target-module reference in
>> dra7-l4.dtsi following the first commit?
>
>Looking at commit 549fce068a31 above, we have dra7-l4.dtsi define a module
>at 0x48940000. But maybe the module is only used for dwc on dra74x?
>
>If this controller instance is on all dra7 SoCs, then it should be in
>dra7-l4.dtsi. If the controller instance is only on dra74x, it should be
>only in dra74x.dtsi file.
>
>Sorry sounds like I have confused some hardware differences along the
>way.

Thanks for the review. The controller instance is seen only in dra74x, pushed
a v2 based on the above suggestion.

Thanks,
Gowtham