linux-kernel - Re: [PATCH] scsi: qla2xxx: Remove redundant assignment to rval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162200196243.11962.2847628665224786477.b4-ty@oracle.com>
Date:   Wed, 26 May 2021 00:07:22 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        njavali@...vell.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        jejb@...ux.ibm.com, GR-QLogic-Storage-Upstream@...vell.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Remove redundant assignment to rval

On Mon, 10 May 2021 18:40:06 +0800, Jiapeng Chong wrote:

> Variable rval is set to QLA_SUCCESS, but this value is never read as
> it is overwritten later on, hence it is a redundant assignment and
> can be removed.
> 
> Clean up the following clang-analyzer warning:
> 
> drivers/scsi/qla2xxx/qla_init.c:4359:2: warning: Value stored to 'rval'
> is never read [clang-analyzer-deadcode.DeadStores].

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Remove redundant assignment to rval
      https://git.kernel.org/mkp/scsi/c/cb9eb11fd572

-- 
Martin K. Petersen	Oracle Linux Engineering