linux-kernel - Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 07:16:18 +1200
From:   Michael Schmitz <schmitzmic@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Michael Schmitz <schmitz@...ian.org>,
        Roman Zippel <zippel@...ux-m68k.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning

Randy,

On 26/05/21 7:03 pm, Randy Dunlap wrote:
> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.

Right you are! Thanks for spotting this.

Reviewed-by: Michael Schmitz <schmitzmic@...il.com>

>
> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
>    Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
>    Selected by [y]:
>    - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>
> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Michael Schmitz <schmitz@...ian.org>
> Cc: Roman Zippel <zippel@...ux-m68k.org>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: linux-input@...r.kernel.org
> ---
>   drivers/input/mouse/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
> +++ linux-next-20210525/drivers/input/mouse/Kconfig
> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>   
>   config MOUSE_ATARI
>   	tristate "Atari mouse"
> +	depends on INPUT_KEYBOARD
>   	depends on ATARI
>   	select ATARI_KBD_CORE
>   	help