linux-kernel - RE: [PATCH v2] ARM: dts: dra7: Fix duplicate USB4 device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 May 2021 19:48:23 +0000
From:   "Tammana, Gowtham" <g-tammana@...com>
To:     "Anna, Suman" <s-anna@...com>,
        "tony@...mide.com" <tony@...mide.com>,
        "bcousson@...libre.com" <bcousson@...libre.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Strashko, Grygorii" <grygorii.strashko@...com>,
        "Menon, Nishanth" <nm@...com>
Subject: RE: [PATCH v2] ARM: dts: dra7: Fix duplicate USB4 device node



>-----Original Message-----
>From: Anna, Suman
>Sent: Wednesday, May 26, 2021 1:01 PM
>
>Hi Gowtham,
>
>On 5/26/21 12:20 PM, Gowtham Tammana wrote:
>> With [1] USB4 device node got defined in dra74x.dtsi file. However,
>> there was a prior defintion of the same in [2] which didn't get removed
>
>I like this approach and is more in line with the original move of USB4
>node
>into dra74x.dtsi file.
>
>Looks like you mixed up [1] and [2] or I misunderstand your terminology.

Yes, 1 and 2 got mixed up here. Will post a v3.

>Also,
>let's be precise, it is the USB4 target-module node that got duplicated in
>[2],
>USB4 node always existed but outside of ti-sysc control before [2] and did
>not
>conflict with the target-module node added in [1].
>
>> causing boot failures.
>
>on what boards? Is it affecting all of them?

I have a dra7-evm board and see failure on it. This should also affect
Dra76-evm, am572x beagle boards, am574x as they all pull in dra74x.dtsi.
Will mention these in the v3 update.

Thanks,
Gowtham 

> USB4 node is present only in DRA74x variants so
>> keeping the entry in dra74x.dtsi and removing it from the top level
>> interconnect hierarchy dra7-l4.dtsi file.
>>
>> Since USB4 is only included in DRA74x variants, remove its reference
>> for AM5718, DRA71x and DR72x boards.
>>
>> [1]: commit 549fce068a311 ("ARM: dts: dra7: Add l4 interconnect
>> hierarchy and ti-sysc data")
>> [2]: commit c7b72abca61ec ("ARM: OMAP2+: Drop legacy platform data for
>> dra7 dwc3")
>>
>> Fixes: c7b72abca61ec ("ARM: OMAP2+: Drop legacy platform data for dra7
>dwc3")
>> Signed-off-by: Gowtham Tammana <g-tammana@...com>
>> ---
>> v2: