linux-kernel - Re: [PATCH] [v2] staging: media: atomisp: Align block comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210526214431.GJ3@paasikivi.fi.intel.com>
Date:   Thu, 27 May 2021 00:44:32 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiabing Wan <kael_w@...h.net>, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] staging: media: atomisp: Align block comments

Hi Jiabing,

On Tue, May 18, 2021 at 07:29:35PM +0800, Wan Jiabing wrote:
> From: Jiabing Wan <kael_w@...h.net>
> 
> Fixing the following checkpatch warning:
> WARNING: Block comments should align the * on each line
> 
> Signed-off-by: Jiabing Wan <kael_w@...h.net>
> ---
> Changelog:
> v2:
> - Fix the author style in patch.
> ---
>  .../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h    | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> index be3534e46c15..9b22f2da45d5 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> @@ -17,8 +17,8 @@
>  #define __IA_CSS_ANR_TYPES_H
>  
>  /* @file

Could you fix the first line, too, i.e.:

/*
 * ...

> -* CSS-API header file for Advanced Noise Reduction kernel v1
> -*/
> + * CSS-API header file for Advanced Noise Reduction kernel v1
> + */
>  
>  /* Application specific DMA settings  */
>  #define ANR_BPP                 10

-- 
Kind regards,

Sakari Ailus