linux-kernel - Re: [PATCH v3] power: supply: sbs-battery: cache constant string properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 May 2021 16:37:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ikjoon Jang <ikjn@...omium.org>, linux-pm@...r.kernel.org,
        Sebastian Reichel <sre@...nel.org>
Cc:     kbuild-all@...ts.01.org, Hsinyi Wang <hsinyi@...omium.org>,
        Ikjoon Jang <ikjn@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] power: supply: sbs-battery: cache constant string
 properties

Hi Ikjoon,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on power-supply/for-next]
[also build test WARNING on v5.13-rc3 next-20210525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ikjoon-Jang/power-supply-sbs-battery-cache-constant-string-properties/20210526-132701
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: i386-randconfig-a015-20210526 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/584859e4c0fe02c3c7b9b4e8c4a2c99d5212fe21
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ikjoon-Jang/power-supply-sbs-battery-cache-constant-string-properties/20210526-132701
        git checkout 584859e4c0fe02c3c7b9b4e8c4a2c99d5212fe21
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/power/supply/sbs-battery.c: In function 'sbs_invalidate_cached_props':
   drivers/power/supply/sbs-battery.c:1288: error: unterminated argument list invoking macro "if"
    1288 |    "Attempt to load the driver even if no battery is connected");
         | 
   drivers/power/supply/sbs-battery.c:1288: error: expected '(' at end of input
    1288 |    "Attempt to load the driver even if no battery is connected");
         | 
         |(
>> drivers/power/supply/sbs-battery.c:236:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     236 |   if (chip->strings[i][0] = 0;
         |   ^~
   drivers/power/supply/sbs-battery.c:1288: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
    1288 |    "Attempt to load the driver even if no battery is connected");
         | 
   drivers/power/supply/sbs-battery.c:1288: note: '-Wmisleading-indentation' is disabled from this point onwards, since column-tracking was disabled due to the size of the code/headers
   drivers/power/supply/sbs-battery.c:236:3: error: expected declaration or statement at end of input
     236 |   if (chip->strings[i][0] = 0;
         |   ^~
   At top level:
   drivers/power/supply/sbs-battery.c:229:13: warning: 'sbs_invalidate_cached_props' defined but not used [-Wunused-function]
     229 | static void sbs_invalidate_cached_props(struct sbs_info *chip)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/power/supply/sbs-battery.c:217:14: warning: 'sbs_get_string_buf' defined but not used [-Wunused-function]
     217 | static char *sbs_get_string_buf(struct sbs_info *chip,
         |              ^~~~~~~~~~~~~~~~~~
   drivers/power/supply/sbs-battery.c:155:41: warning: 'sbs_properties' defined but not used [-Wunused-const-variable=]
     155 | static const enum power_supply_property sbs_properties[] = {
         |                                         ^~~~~~~~~~~~~~
   drivers/power/supply/sbs-battery.c:97:3: warning: 'sbs_data' defined but not used [-Wunused-const-variable=]
      97 | } sbs_data[] = {
         |   ^~~~~~~~


vim +/if +236 drivers/power/supply/sbs-battery.c

   228	
   229	static void sbs_invalidate_cached_props(struct sbs_info *chip)
   230	{
   231		int i = 0;
   232	
   233		chip->technology = -1;
   234	
   235		for (i = 0; i < NR_STRING_BUFFERS; i++)
 > 236			if (chip->strings[i][0] = 0;
   237	}
   238	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33597 bytes)