linux-kernel - Re: [PATCH] drivers: media: Simplify the return expression of interpolate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 May 2021 12:06:57 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     zuoqilin1@....com, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        zuoqilin <zuoqilin@...ong.com>
Subject: Re: [PATCH] drivers: media: Simplify the return expression of
 interpolate_value()

Please include the driver you are changing in the subject line. I asked for that
before. Just saying 'drivers: media:' suggests it is a media-subsystem wide change.

Rejecting this and the other patch you posted on the same day with the same problem.

Regards,

	Hans

On 24/05/2021 14:47, zuoqilin1@....com wrote:
> From: zuoqilin <zuoqilin@...ong.com>
> 
> Simplify the return expression.
> 
> Signed-off-by: zuoqilin <zuoqilin@...ong.com>
> ---
>  drivers/media/dvb-frontends/mb86a20s.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c
> index a7faf0c..fc80391 100644
> --- a/drivers/media/dvb-frontends/mb86a20s.c
> +++ b/drivers/media/dvb-frontends/mb86a20s.c
> @@ -1346,7 +1346,7 @@ static u32 interpolate_value(u32 value, const struct linear_segments *segments,
>  {
>  	u64 tmp64;
>  	u32 dx, dy;
> -	int i, ret;
> +	int i;
>  
>  	if (value >= segments[0].x)
>  		return segments[0].y;
> @@ -1367,9 +1367,7 @@ static u32 interpolate_value(u32 value, const struct linear_segments *segments,
>  	tmp64 = value - segments[i].x;
>  	tmp64 *= dy;
>  	do_div(tmp64, dx);
> -	ret = segments[i].y - tmp64;
> -
> -	return ret;
> +	return segments[i].y - tmp64;
>  }
>  
>  static int mb86a20s_get_main_CNR(struct dvb_frontend *fe)
>