linux-kernel - Re: [PATCH] pci-hyperv: Add check for hyperv_initialized in init_hv_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210526100805.xpeen7td45cswqsw@liuwe-devbox-debian-v2>
Date:   Wed, 26 May 2021 10:08:05 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Haiyang Zhang <haiyangz@...rosoft.com>
Cc:     bhelgaas@...gle.com, lorenzo.pieralisi@....com, wei.liu@...nel.org,
        linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
        kys@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci-hyperv: Add check for hyperv_initialized in
 init_hv_pci_drv()

On Tue, May 25, 2021 at 04:17:33PM -0700, Haiyang Zhang wrote:
> Add check for hv_is_hyperv_initialized() at the top of init_hv_pci_drv(),
> so if the pci-hyperv driver is force-loaded on non Hyper-V platforms, the
> init_hv_pci_drv() will exit immediately, without any side effects, like
> assignments to hvpci_block_ops, etc.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reported-and-tested-by: Mohammad Alqayeem <mohammad.alqyeem@...anix.com>

Reviewed-by: Wei Liu <wei.liu@...nel.org>

> ---
>  drivers/pci/controller/pci-hyperv.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 6511648271b2..bebe3eeebc4e 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -3476,6 +3476,9 @@ static void __exit exit_hv_pci_drv(void)
>  
>  static int __init init_hv_pci_drv(void)
>  {
> +	if (!hv_is_hyperv_initialized())
> +		return -ENODEV;
> +
>  	/* Set the invalid domain number's bit, so it will not be used */
>  	set_bit(HVPCI_DOM_INVALID, hvpci_dom_map);
>  
> -- 
> 2.25.1
>