linux-kernel - Re: [PATCH] module: correctly exit module_kallsyms_on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YK5F/7LEWj0juiOw@p200300cbcf361a0029e37a38368d6727.dip0.t-ipconnect.de>
Date:   Wed, 26 May 2021 14:58:39 +0200
From:   Jessica Yu <jeyu@...nel.org>
To:     Jon Mediero <jmdr@...root.org>
Cc:     Petr Mladek <pmladek@...e.com>, Miroslav Benes <mbenes@...e.cz>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: correctly exit module_kallsyms_on_each_symbol
 when fn() != 0

+++ Jon Mediero [20/05/21 14:23 +0200]:
>Commit 013c1667cf78 ("kallsyms: refactor
>{,module_}kallsyms_on_each_symbol") replaced the return inside the
>nested loop with a break, changing the semantics of the function: the
>break only exits the innermost loop, so the code continues iterating the
>symbols of the next module instead of exiting.
>
>Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
>Signed-off-by: Jon Mediero <jmdr@...root.org>

Good catch, thanks a lot for the fix! Applied to modules-next.

Jessica