linux-kernel - [PATCH] virt/kvm/kvm_main.c: use vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210526140020.2021-1-hbut_tan@163.com>
Date:   Wed, 26 May 2021 22:00:20 +0800
From:    Zhongjun Tan <hbut_tan@....com>
To:     pbonzini@...hat.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tan Zhongjun <tanzhongjun@...ong.com>
Subject: [PATCH] virt/kvm/kvm_main.c: use vma_pages() helper

From: Tan Zhongjun <tanzhongjun@...ong.com>

Use vma_pages function on vma object instead of explicit computation.
./virt/kvm/kvm_main.c:3247:29-35: WARNING: Consider using vma_pages helper on vma

Signed-off-by: Tan Zhongjun <tanzhongjun@...ong.com>
---
 virt/kvm/kvm_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 6b4feb92dc79..1ac52cd1111d 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -3244,7 +3244,7 @@ static const struct vm_operations_struct kvm_vcpu_vm_ops = {
 static int kvm_vcpu_mmap(struct file *file, struct vm_area_struct *vma)
 {
 	struct kvm_vcpu *vcpu = file->private_data;
-	unsigned long pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+	unsigned long pages = vma_pages(vma);
 
 	if ((kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff) ||
 	     kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff + pages - 1)) &&
-- 
2.17.1