linux-kernel - Re: [External] [PATCH 0/2] Track reserve map changes to restore on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtVUvtCCEHN_V8iE4m9FAmiz9e5Z1CNNvnetXsrEwAVzgQ@mail.gmail.com>
Date:   Wed, 26 May 2021 11:19:20 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Mike Kravetz <mike.kravetz@...cle.com>
Cc:     Mina Almasry <almasrymina@...gle.com>,
        Linux-MM <linux-mm@...ck.org>,
        open list <linux-kernel@...r.kernel.org>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Peter Xu <peterx@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [External] [PATCH 0/2] Track reserve map changes to restore on error

On Wed, May 26, 2021 at 7:31 AM Mike Kravetz <mike.kravetz@...cle.com> wrote:
>
> Here is a modification to the reservation tracking for fixup on errors.
> It is a more general change, but should work for the hugetlb_mcopy_pte_atomic
> case as well.
>
> Perhaps use this as a prerequisite for your fix(es)?  Pretty sure this
> will eliminate the need for the call to hugetlb_unreserve_pages.

Hi Mike,

It seems like someone is fixing a bug, right? Maybe a link should be
placed in the cover letter so that someone can know what issue
we are facing.

Thanks.

>
> Mike Kravetz (2):
>   hugetlb: rename HPageRestoreReserve flag to HPageRestoreRsvCnt
>   hugetlb: add new hugetlb specific flag HPG_restore_rsv_map
>
>  fs/hugetlbfs/inode.c    |   3 +-
>  include/linux/hugetlb.h |  17 +++++--
>  mm/hugetlb.c            | 108 ++++++++++++++++++++++++++++------------
>  mm/userfaultfd.c        |  14 +++---
>  4 files changed, 99 insertions(+), 43 deletions(-)
>
> --
> 2.31.1
>