linux-kernel - Re: [PATCH 24/24] usb: typec: ucsi: Fix copy/paste issue for 'ucsi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YK5caP3nNiAsaC6e@kuha.fi.intel.com>
Date:   Wed, 26 May 2021 17:34:16 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 24/24] usb: typec: ucsi: Fix copy/paste issue for
 'ucsi_set_drvdata()'

On Wed, May 26, 2021 at 02:00:37PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/usb/typec/ucsi/ucsi.c:1287: warning: expecting prototype for ucsi_get_drvdata(). Prototype was for ucsi_set_drvdata() instead
> 
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index b433169ef6fa4..4e1973fbdf0dc 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1279,7 +1279,7 @@ void *ucsi_get_drvdata(struct ucsi *ucsi)
>  EXPORT_SYMBOL_GPL(ucsi_get_drvdata);
>  
>  /**
> - * ucsi_get_drvdata - Assign private driver data pointer
> + * ucsi_set_drvdata - Assign private driver data pointer
>   * @ucsi: UCSI interface
>   * @data: Private data pointer
>   */
> -- 
> 2.31.1

-- 
heikki