linux-kernel - Re: [PATCH][next] acpi: power: remove redundant initialization of variable result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hfi9mZb-9Zb5FGUn1mC9L8hAacpmDDzbDtB+prZczt4A@mail.gmail.com>
Date:   Wed, 26 May 2021 16:43:40 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] acpi: power: remove redundant initialization of
 variable result

On Wed, May 26, 2021 at 4:12 PM Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> The variable result is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/acpi/power.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 97c9a94a1a30..d86865c04f64 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -919,7 +919,7 @@ struct acpi_device *acpi_add_power_resource(acpi_handle handle)
>         union acpi_object acpi_object;
>         struct acpi_buffer buffer = { sizeof(acpi_object), &acpi_object };
>         acpi_status status;
> -       int state, result = -ENODEV;
> +       int state, result;
>
>         acpi_bus_get_device(handle, &device);
>         if (device)
> --

Equivalent change is made in

https://patchwork.kernel.org/project/linux-acpi/patch/2786380.e9J7NaK4W3@kreacher/

Thanks!