linux-kernel - Re: [RESEND PATCH v2 06/13] mfd: wm831x: Correct kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210526144907.GC543307@dell>
Date:   Wed, 26 May 2021 15:49:07 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Support Opensource <support.opensource@...semi.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org,
        patches@...nsource.cirrus.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>
Subject: Re: [RESEND PATCH v2 06/13] mfd: wm831x: Correct kerneldoc

On Wed, 26 May 2021, Krzysztof Kozlowski wrote:
65;6200;1c
> Correct kerneldoc function name to fix W=1 warning:
> 
>   drivers/mfd/wm831x-core.c:121: warning:
>     expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> 
> ---
> 
> Changes since v1:
> 1. Add Ack
> ---
>  drivers/mfd/wm831x-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This one has been fixed already:

https://lore.kernel.org/lkml/20210520120820.3465562-2-lee.jones@linaro.org/

> diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c
> index bcef08f58fb3..c31809b17547 100644
> --- a/drivers/mfd/wm831x-core.c
> +++ b/drivers/mfd/wm831x-core.c
> @@ -109,7 +109,7 @@ static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg)
>  }
>  
>  /**
> - * wm831x_reg_unlock: Unlock user keyed registers
> + * wm831x_reg_lock: Unlock user keyed registers
>   *
>   * The WM831x has a user key preventing writes to particularly
>   * critical registers.  This function locks those registers,

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog