linux-kernel - Re: [PATCH v7 1/3] perf report: compile tips.txt in perf binary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 May 2021 14:50:24 +0000
From:   "Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)" 
        <dzagorui@...co.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     "jolsa@...hat.com" <jolsa@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>
Subject: Re: [PATCH v7 1/3] perf report: compile tips.txt in perf binary

> [perfbuilder@...e ~]$ export PERF_TARBALL=http://192.168.100.2/perf/perf-5.13.0-rc3.tar.xz
> [perfbuilder@...e ~]$ time dm
> Wed May 26 11:04:00 AM -03 2021
> # export PERF_TARBALL=http://192.168.100.2/perf/perf-5.13.0-rc3.tar.xz
> # dm
>   1     9.39 alpine:3.4                    : FAIL gcc version 5.3.0 (Alpine 5.3.0)
>    builtin-report.c: In function 'cmd_report':
>    builtin-report.c:560:3: error: 'prev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>       fprintf(stdout, "#\n# (%s)\n#\n", help);
>       ^
>    builtin-report.c:622:20: note: 'prev' was declared here
>      char *tok, *tmp, *prev;
> <SNIP>
>
>  10    13.35 alpine:3.13                   : FAIL gcc version 10.2.1 20201203 (Alpine 10.2.1_pre1)
>    builtin-report.c: In function 'cmd_report':
>    builtin-report.c:560:3: error: 'prev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      560 |   fprintf(stdout, "#\n# (%s)\n#\n", help);
>          |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    builtin-report.c:622:20: note: 'prev' was declared here
>      622 |  char *tok, *tmp, *prev;
>          |                    ^~~~
>    cc1: all warnings being treated as errors
>  11    13.77 alpine:edge                   : FAIL gcc version 10.3.1 20210424 (Alpine 10.3.1_git20210424)
>    builtin-report.c: In function 'cmd_report':
>    builtin-report.c:560:3: error: 'prev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      560 |   fprintf(stdout, "#\n# (%s)\n#\n", help);
>          |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    builtin-report.c:622:20: note: 'prev' was declared here
>      622 |  char *tok, *tmp, *prev;
>          |                    ^~~~
>    cc1: all warnings being treated as errors
>
>
> I'll check later...

prev should be initialized to _binary_Documentation_tips_txt_start, i can resend 


Thanks,
Denys