linux-kernel - Re: [External] [PATCH v2 2/4] slub: Actually use 'message' in restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtVF+D_o3V8TEt5ro03TELT2RibWZp=b8H+4pNR1gJh6AQ@mail.gmail.com>
Date:   Wed, 26 May 2021 11:29:50 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Petr Mladek <pmladek@...e.com>, Joe Perches <joe@...ches.com>
Subject: Re: [External] [PATCH v2 2/4] slub: Actually use 'message' in restore_bytes()

On Wed, May 26, 2021 at 10:56 AM Stephen Boyd <swboyd@...omium.org> wrote:
>
> The message argument isn't used here. Let's pass the string to the
> printk message so that the developer can figure out what's happening,
> instead of guessing that a redzone is being restored, etc.
>
> Reviewed-by: Vlastimil Babka <vbabka@...e.cz>
> Acked-by: David Rientjes <rientjes@...gle.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
>

More convenient. LGTM.

Reviewed-by: Muchun Song <songmuchun@...edance.com>