linux-kernel - Re: [PATCH] coresight: Propagate symlink failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210527155135.GA1297106@xps15>
Date:   Thu, 27 May 2021 09:51:35 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Jeremy Linton <jeremy.linton@....com>
Cc:     coresight@...ts.linaro.org, suzuki.poulose@....com,
        mike.leach@...aro.org, leo.yan@...aro.org,
        alexander.shishkin@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: Propagate symlink failure

On Wed, May 26, 2021 at 03:40:42PM -0500, Jeremy Linton wrote:
> If the symlink is unable to be created, the driver goes
> ahead and continues device creation. Instead lets propagate
> the failure, and fail the probe.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>
> ---
>  drivers/hwtracing/coresight/coresight-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 6c68d34d956e..2dc4b0110442 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1392,7 +1392,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev)
>  		}
>  	}
>  
> -	return 0;
> +	return ret;

I have applied your patch.

Thanks,
Mathieu

>  }
>  
>  static int coresight_remove_match(struct device *dev, void *data)
> -- 
> 2.31.1
>