linux-kernel - Re: [PATCH v5 2/2] writeback, cgroup: release dying cgwbs by switching attached inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YK/JBDxsZQwC0q8J@carbon.DHCP.thefacebook.com>
Date:   Thu, 27 May 2021 09:29:56 -0700
From:   Roman Gushchin <guro@...com>
To:     Hillf Danton <hdanton@...a.com>
CC:     Jan Kara <jack@...e.cz>, Tejun Heo <tj@...nel.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>, Alexander Viro <viro@...iv.linux.org.uk>,
        Dennis Zhou <dennis@...nel.org>,
        Dave Chinner <dchinner@...hat.com>, <cgroups@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] writeback, cgroup: release dying cgwbs by
 switching attached inodes

On Thu, May 27, 2021 at 11:24:59AM +0800, Hillf Danton wrote:
> On Wed, 26 May 2021 15:25:57 -0700 Roman Gushchin wrote:
> >+
> >+	if (!list_empty(&offline_cgwbs))
> >+		schedule_work(&cleanup_offline_cgwbs_work);
> >+
> 
> Good work overall.

Thanks!

> 
> Nit, given cond_resched_lock() in cleanup_offline_wb(), what you need instead
> is
> 	queue_work(system_unbound_wq, &cleanup_offline_cgwbs_work);

Neat, will do in the next version.

Thanks!