linux-kernel - Re: [PATCH] selftests/seccomp: More closely track fds being assigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 11:37:47 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Rodrigo Campos <rodrigo@...volk.io>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Sargun Dhillon <sargun@...gun.me>, containers@...ts.linux.dev,
        Tycho Andersen <tycho@...ho.pizza>,
        Mauricio Vásquez Bernal 
        <mauricio@...volk.io>, Giuseppe Scrivano <gscrivan@...hat.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Mickaël Salaün <mic@...ux.microsoft.com>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>
Subject: Re: [PATCH] selftests/seccomp: More closely track fds being assigned

On Thu, May 27, 2021 at 02:45:26PM +0200, Rodrigo Campos wrote:
> On Thu, May 27, 2021 at 5:29 AM Kees Cook <keescook@...omium.org> wrote:
> >
> > Since the open fds might not always start at "4" (especially when
> > running under kselftest, etc), start counting from the first assigned
> > fd, rather than using the more permissive EXPECT_GE(fd, 0).
> >
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> 
> Nice cleanup, thanks! Just in case, tested it here, works fine. Feel
> free to add:
> 
> Reviewed-by: Rodrigo Campos <rodrigo@...volk.io>

Thanks!

> I can improve the selftest to test the new addfd flag we just added
> also in combination existing flags (like setting the fd number to
> use), and maybe also split the big chunk test, if you think that is
> valuable.

Yeah, I was pondering splitting the test up, but I think it's okay how
it is for now.

-- 
Kees Cook