linux-kernel - Re: [PATCH] staging: media: atomisp: pci: Remove checks before kfree/kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210527195222.GK3@paasikivi.fi.intel.com>
Date:   Thu, 27 May 2021 22:52:23 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: pci: Remove checks before
 kfree/kvfree

On Thu, May 27, 2021 at 09:39:22PM +0200, Fabio M. De Francesco wrote:
> Removed checks for pointers != NULL before freeing memory. If kvfree()
> and kfree() are given NULL pointers no operations are performed, so
> there is no need for the above-mentioned checks. Coccinelle detected the
> second of the two unnecessary checks.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Sakari Ailus